fix(tui): correct hermes-ink bundle filename in staleness check#20951
Closed
AKC777 wants to merge 1 commit into
Closed
fix(tui): correct hermes-ink bundle filename in staleness check#20951AKC777 wants to merge 1 commit into
AKC777 wants to merge 1 commit into
Conversation
_hermes_ink_bundle_stale() checks for ink-bundle.js but esbuild outputs entry-exports.js. Since the expected file never exists, _tui_build_needed() always returns True, triggering a full npm run build (~15s) on every dashboard chat WebSocket connection. This causes the Chat tab to show [session ended] due to client timeout.
Collaborator
This was referenced May 7, 2026
This was referenced May 16, 2026
Contributor
|
Closing as stale — the code path this addresses no longer exists on Triage notes (high confidence): If this PR's intent is still relevant against the current code, please rebase or open a fresh PR. (Bulk-closed during a CLI PR triage sweep.) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_hermes_ink_bundle_stale()checks forpackages/hermes-ink/dist/ink-bundle.js, but the hermes-ink build script (esbuild) outputsdist/entry-exports.js. Since the expected file never exists,_tui_build_needed()always returnsTrue, triggering a fullnpm run buildon every dashboard chat WebSocket connection (~15 seconds of blocking I/O).This causes the Chat tab in
hermes dashboard --tuito time out and show[session ended]immediately.Fix
Update the expected filename from
ink-bundle.jstoentry-exports.jsto match what esbuild actually produces.Reproduction
hermes dashboard --host 0.0.0.0 --port 9119 --tui --insecure[session ended]immediately — the WS handler blocks for ~15s onnpm run buildTest Plan
_hermes_ink_bundle_stale()returnsFalsewhenentry-exports.jsis up-to-date_make_tui_argv()completes in <1 second when no rebuild is needed