feat(dashboard): add --allowed-host flag for reverse proxy support#20884
Closed
tobalsan wants to merge 1 commit into
Closed
feat(dashboard): add --allowed-host flag for reverse proxy support#20884tobalsan wants to merge 1 commit into
tobalsan wants to merge 1 commit into
Conversation
Allows the dashboard to accept extra Host header values via a repeatable --allowed-host CLI flag. This enables running the dashboard behind Tailscale Serve (or any reverse proxy) without binding to 0.0.0.0. Usage: hermes dashboard --no-open --allowed-host host.tailnet.ts.net The dashboard stays on 127.0.0.1 -- Tailscale Serve proxies to it over loopback, so WebSockets work unchanged.
Collaborator
Author
|
Closed as it's a duplicate of #20136 |
19 tasks
19 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The dashboard's Host header validation (anti-DNS-rebinding, GHSA-ppp5-vxwm-4cf7) rejects any request whose Host doesn't match the bound interface. This makes it impossible to run behind a reverse proxy like Tailscale Serve that rewrites the Host header to the proxy's hostname.
Solution
Add a repeatable
--allowed-hostCLI flag that registers extra accepted Host header values:Changes:
web_server.py:_is_accepted_host()gains anextra_hostsparameter, checked before existing logic. Stored onapp.statebystart_server().main.py: New--allowed-hostarg on the dashboard subparser, threaded through tostart_server().No changes to existing behavior — the flag is additive and defaults to empty.