fix(gateway): stop bare local paths from being uploaded in post-stream media delivery#20843
Open
liuhao1024 wants to merge 3 commits into
Open
fix(gateway): stop bare local paths from being uploaded in post-stream media delivery#20843liuhao1024 wants to merge 3 commits into
liuhao1024 wants to merge 3 commits into
Conversation
…INSTALL_TIMEOUT Increase the default npm install timeout for WhatsApp bridge from 60s to 300s (5 minutes) to accommodate slower systems like Unraid NAS. Make it configurable via WHATSAPP_NPM_INSTALL_TIMEOUT environment variable for users who need even longer timeouts. Closes NousResearch#14980
- Add 'path', 'old_string', 'new_string', and 'patch' to required list - Update description to clarify mode-specific parameter requirements - This addresses issue where LLMs would omit these parameters because they were not marked as required in the schema, even though they are required depending on the mode Fixes NousResearch#15524
…m media delivery Remove extract_local_files() call from _deliver_media_from_response() so that only explicit MEDIA: directives trigger file uploads after streaming. Bare local paths mentioned in tool output or response text are no longer promoted into attachments. Fixes NousResearch#20834
19 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Remove the
extract_local_files()call fromGatewayRunner._deliver_media_from_response()so that only explicitMEDIA:directives trigger file uploads after streaming completes.Root Cause
_deliver_media_from_response()mixed two behaviors:MEDIA:directives from the response → upload intended filesThe implicit path (
extract_local_files(cleaned)) caused the gateway to upload files whose paths happened to appear in tool output or assistant text, even when the final visible reply contained no attachment directive.This is especially dangerous in streaming mode because:
Related Issue
N/A
Type of Change
Changes Made
How to Test
pytest tests/ -q— all tests should passChecklist
Code
fix(scope):,feat(scope):, etc.)pytest tests/ -qand all tests passDocumentation & Housekeeping
docs/, docstrings) — or N/Acli-config.yaml.exampleif I added/changed config keys — or N/ACONTRIBUTING.mdorAGENTS.mdif I changed architecture and workflows — or N/A