Avoid clobbering symlinked hermes launcher during install#20747
Closed
vKongv wants to merge 3 commits into
Closed
Conversation
1 task
7a96b1b to
0c72feb
Compare
0c72feb to
a571984
Compare
a571984 to
6ab5875
Compare
This was referenced May 12, 2026
6ab5875 to
943962c
Compare
943962c to
015214b
Compare
015214b to
d9efde1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Prevent
scripts/install.shfrom overwriting the realvenv/bin/hermesentrypoint when the user-facing launcher path is a symlink back into the venv.Changes
hermesPYTHONPATH/PYTHONHOMEsanitization behavior intactTests
scripts/run_tests.sh tests/test_install_sh_pythonpath_sanitization.py