fix(curator): make manual runs synchronous#20556
Closed
LeonSGP43 wants to merge 1 commit into
Closed
Conversation
steezkelly
approved these changes
May 6, 2026
steezkelly
left a comment
Contributor
There was a problem hiding this comment.
Verified this PR against the curator CLI failure I reported in #20555.
Checks run locally in a clean detached worktree for this PR:
scripts/run_tests.sh tests/hermes_cli/test_curator_run.py tests/hermes_cli/test_curator_status.py tests/hermes_cli/test_curator_archive_prune.py tests/agent/test_curator_reports.py tests/agent/test_curator.py tests/agent/test_curator_activity.py tests/agent/test_curator_classification.py tests/agent/test_curator_backup.py
144 passed
ruff check hermes_cli/curator.py tests/hermes_cli/test_curator_run.py tests/hermes_cli/test_curator_status.py
All checks passed
python -m py_compile hermes_cli/curator.py tests/hermes_cli/test_curator_run.py tests/hermes_cli/test_curator_status.py
passed
git diff --check origin/main...HEAD
clean
The implementation matches the intended fix: manual hermes curator run / --dry-run now waits for the LLM/report phase by default, --background preserves legacy async behavior, and --sync wins if both flags are supplied. I do not see a blocker.
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
hermes curator runandhermes curator run --dry-runwait for the curator LLM/report pass by default--backgroundfor the legacy non-blocking behavior, with--synctaking precedencelast_report_pathvalues inhermes curator statusso stale paths are visibleFixes #20555.
Verification
scripts/run_tests.sh tests/hermes_cli/test_curator_run.py tests/hermes_cli/test_curator_status.py-> 9 passedscripts/run_tests.sh tests/hermes_cli/test_curator_run.py tests/hermes_cli/test_curator_status.py tests/hermes_cli/test_curator_archive_prune.py tests/agent/test_curator_reports.py tests/agent/test_curator.py tests/agent/test_curator_activity.py tests/agent/test_curator_classification.py tests/agent/test_curator_backup.py-> 144 passedruff check hermes_cli/curator.py tests/hermes_cli/test_curator_run.py tests/hermes_cli/test_curator_status.py-> passedpython -m py_compile hermes_cli/curator.py tests/hermes_cli/test_curator_run.py tests/hermes_cli/test_curator_status.py-> passedgit diff --check-> clean