fix(webhook): support Svix signatures#20518
Conversation
|
Thanks for picking this up. I ran into this with AgentMail webhooks as well, and the core HMAC calculation here matches the Svix/AgentMail format. A couple of things look worth tightening before merge:
The implementation otherwise looks like it should unblock AgentMail's signature format without adding a new runtime dependency. |
|
This looks implemented on current main by the merged Svix/AgentMail webhook work in #30200, so I'm marking this overlapping PR as stale to close. This is an automated hermes-sweeper review. Evidence:
Thanks for picking this up originally; the merged path appears to have incorporated the useful review feedback from the discussion here. |
Summary
svix-id/svix-timestamp/svix-signatureverification to the webhook adapterwhsec_signing secrets and multiple space-delimitedv1,<base64>signaturesCloses #20478
Tests
scripts/run_tests.sh tests/gateway/test_webhook_adapter.py -k 'svix or ValidateSignature'\n-scripts/run_tests.sh tests/gateway/test_webhook_adapter.py\n-git diff --check