Skip to content

feat(i18n): add Ukrainian locale#20287

Closed
olisikh wants to merge 2 commits into
NousResearch:mainfrom
olisikh:feat/i18n-ukrainian
Closed

feat(i18n): add Ukrainian locale#20287
olisikh wants to merge 2 commits into
NousResearch:mainfrom
olisikh:feat/i18n-ukrainian

Conversation

@olisikh

@olisikh olisikh commented May 5, 2026

Copy link
Copy Markdown
Contributor

Summary

  • add Ukrainian (uk) to the static i18n supported language list
  • add locales/uk.yaml with CLI approval and gateway static-message translations
  • document display.language: uk and cover Ukrainian aliases in i18n tests

Test Plan

  • python -m pytest tests/agent/test_i18n.py -q
  • python -m pytest tests/agent/test_i18n.py tests/hermes_cli/test_config.py -q

@alt-glitch alt-glitch added type/feature New feature or request P3 Low — cosmetic, nice to have comp/agent Core agent loop, run_agent.py, prompt builder comp/cli CLI entry point, hermes_cli/, setup wizard labels May 5, 2026
@teknium1

teknium1 commented May 6, 2026

Copy link
Copy Markdown
Contributor

Merged via PR #20467. Your feat(i18n): add Ukrainian locale commit was cherry-picked onto current main with your authorship preserved in git log.

Salvage notes:

  • Resolved conflicts against the French locale PR that landed in the meantime — both fr and uk are now supported.
  • Fixed a downstream SyntaxError in agent/i18n.py introduced by the cross-PR rebase (module docstring was missing its closing """).
  • Added AUTHOR_MAP entry for your email.

Thanks for the contribution!

@teknium1 teknium1 closed this May 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp/agent Core agent loop, run_agent.py, prompt builder comp/cli CLI entry point, hermes_cli/, setup wizard P3 Low — cosmetic, nice to have type/feature New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants