fix(android): use Node.js API for esbuild + pip timeout/skips for Termux#19841
Closed
jimmyjonezz wants to merge 1 commit into
Closed
fix(android): use Node.js API for esbuild + pip timeout/skips for Termux#19841jimmyjonezz wants to merge 1 commit into
jimmyjonezz wants to merge 1 commit into
Conversation
- hermes-ink: build script uses Node.js API instead of CLI (native binary broken on Termux/Android arm64) - hermes-ink: prepare hook auto-patches build after npm install - hermes_cli: _install_python_deps skips voice extra on Termux - hermes_cli: add timeout (300s) to pip install calls
Collaborator
1 similar comment
Collaborator
Contributor
|
Closing as superseded by #21489. Triage notes (high confidence): Thanks for the contribution — the underlying problem this PR addresses has been resolved by the linked PR on current main. If you believe this was closed in error, please comment and we'll reopen. (Bulk-closed during a CLI PR triage sweep.) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes two issues when running Hermes Agent on Termux/Android (Python 3.13, arm64):
1. esbuild CLI broken on Android
The
@esbuild/android-arm64native binary fails with ELF "bad shdr" error when invoked via shell (execFileSync). The Node.js API works correctly.Changes:
hermes-inkbuild script now usesnode -e "const esbuild=require(...)..."instead of CLIpreparehook +fix-build.jsto auto-patch the build script afternpm install(surviveshermes update)2. pip install hangs on unavailable extras
faster-whisper/ctranslate2have no wheels for Python 3.13 arm64 Android. Duringhermes update, thevoiceextra causes pip to hang indefinitely.Changes in
_install_python_dependencies_with_optional_fallback:voiceextra on Termux (detected by/com.termux/in__file__path)TimeoutExpiredand continues gracefullyTesting
npm run buildinhermes-inksucceeds on Androidnpm run prepareauto-patches build scriptnpm run buildinui-tui) succeedshermes updatecompletes without hanging onvoiceextraCloses: Termux/Android compatibility