fix(install): include Matrix support in the default full install#1979
Closed
cutepawss wants to merge 1 commit into
Closed
fix(install): include Matrix support in the default full install#1979cutepawss wants to merge 1 commit into
cutepawss wants to merge 1 commit into
Conversation
This was referenced Mar 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1973
Summary
Fresh installs that use
uv pip install -e ".[all]"oruv pip install -e ".[all,dev]"do not install Matrix support, even though Matrix can be configured inhermes gateway setup.The
matrixextra is defined inpyproject.toml, but it was not included in theallextra. As a result, a fresh install can collect Matrix credentials successfully, but gateway startup still fails with:Fix
Added
hermes-agent[matrix]to theallextra inpyproject.toml.This keeps Matrix as an optional extra for targeted installs, while making the default full install match the behavior implied by the setup flow and install docs.
Tests
Added
tests/test_project_metadata.py::test_all_extra_includes_matrix_dependencyto prevent thematrixextra from being dropped fromallagain.Verified under Python 3.11:
Also re-checked the existing
.[all]update/install path tests: