docs: default custom tool creation to plugins#19755
Merged
Merged
Conversation
Steers custom tool creation toward the plugin route by default.
The adding-tools.md guide is now explicitly for built-in core Hermes
tools only.
Key fixes:
- Plugin quickstart: ctx.register_tool() now uses correct keyword-arg
API (name=, toolset=, schema=, handler=) instead of broken 3-arg call
- Handler signature: (params, **kwargs) instead of (params)
- Handler return: json.dumps({...}) instead of plain string
- AGENTS.md: mentions plugin route before built-in tool instructions
- learning-path.md: plugins listed before core tool development
- contributing.md: separates plugin vs core tool paths
Based on PR #13138 by @helix4u.
19 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Salvage of PR #13138 by @helix4u.
Steers custom tool creation toward the plugin route by default. The
adding-tools.mdguide is now explicitly for built-in core Hermes tools only.Critical fix: The plugin quickstart example in
plugins.mdused the old incorrect 3-argctx.register_tool("hello_world", schema, handle_hello)call which TypeErrors at runtime. Fixed to use the current keyword-arg API withtoolset=parameter, correct handler signature(params, **kwargs), andjson.dumps()return.Changes (5 files):
AGENTS.md— mention plugin route before built-in tool instructionswebsite/docs/developer-guide/adding-tools.md— add warning banner, rename steps to "Built-in", add plugin-check to checklistwebsite/docs/developer-guide/contributing.md— separate plugin vs core tool pathswebsite/docs/getting-started/learning-path.md— plugins listed before core tool devwebsite/docs/user-guide/features/plugins.md— fix quickstart example + add steering note