fix(kanban): reject direct status transition to 'running' via dashboard API#19554
Closed
luyao618 wants to merge 0 commit into
Closed
fix(kanban): reject direct status transition to 'running' via dashboard API#19554luyao618 wants to merge 0 commit into
luyao618 wants to merge 0 commit into
Conversation
Collaborator
|
Closes #19535 — same fix (reject direct status=running via dashboard API). |
Collaborator
|
Closes #19535 |
5071b67 to
13a7cbc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The Kanban dashboard PATCH
/tasks/:idendpoint allows settingstatus='running'via_set_status_direct(), bypassing the dispatcher/claim path (kanban_db.claim_task()) that atomically creates run rows, claim locks, expiry timestamps, and worker process metadata.Problem
A dashboard/API caller can transition any task to
runningwithout an active worker, claim lock, ortask_runsrow. These tasks become stuck inrunningstate with no way to recover except manual DB intervention, and violate Kanban's run-history invariants.Fix
Reject
status='running'with HTTP 400 in the dashboard PATCH handler, requiring all transitions torunningto go through the canonicalclaim_task()dispatcher path.Scope
plugins/kanban/dashboard/plugin_api.py: 1 file, 6 lines changedTesting
Closes #19535