feat: Skill Evaluation Gate — universal skill loading (no keywords)#19524
Closed
Cyrene963 wants to merge 1 commit into
Closed
feat: Skill Evaluation Gate — universal skill loading (no keywords)#19524Cyrene963 wants to merge 1 commit into
Cyrene963 wants to merge 1 commit into
Conversation
… keywords) Replace keyword-based skill auto-injection with a code-enforced gate that leverages the LLM's own semantic understanding to select relevant skills. How it works: 1. System prompt includes all skill names + descriptions (existing mechanism) 2. A mandatory instruction tells the agent to evaluate skills before acting 3. A pre_tool_call hook BLOCKS non-read tools until skill_view() is called 4. After skill_view() is called once, the gate opens for the rest of the session This is universal (works for any language), lightweight (no extra API calls), and code-enforced (agent cannot skip it). No keyword matching. Changes: - agent/skill_eval_gate.py: New module with gate logic and instruction text - run_agent.py: Integrate gate into system prompt + both tool dispatch paths
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closing — all changes merged into PR #18316 (feature/semantic-skill-retrieval). The Skill Evaluation Gate is now part of the unified solution with FTS5 + hybrid selector + gate enforcement.