fix(agent): honor configured model max_tokens#19452
Closed
LeonSGP43 wants to merge 1 commit into
Closed
Conversation
This was referenced May 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
model.max_tokensfromconfig.yamlwhenAIAgentis not constructed with an explicitmax_tokensmax_tokensas the highest-priority valuemodel.max_tokensin the gateway agent cache signature so config edits rebuild cached agentsWhy
Custom OpenAI-compatible proxies that translate tool-using chat-completions requests to Anthropic Messages can reject requests that omit
max_tokens. Hermes already had an internalmax_tokenspath, but users could not set it fromconfig.yaml, so custom-provider setups had no stable way to emit the field.Verification
Result: 4 passed, with the existing
tests/conftest.pyevent-loop deprecation warning.Fixes #19360