fix(cli): replace get_event_loop() with get_running_loop() to silence RuntimeWarning in process_loop thread#19435
Closed
oluwadareab12 wants to merge 1 commit into
Conversation
… RuntimeWarning in process_loop thread (NousResearch#19285)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #19285
Root cause: Two calls to
asyncio.get_event_loop()(orget_event_loop_policy().get_event_loop()) in cli.py emit a DeprecationWarning on Python 3.10/3.11 and a RuntimeWarning on Python 3.12+ when called from a background thread (e.g. process_loop) that has no current event loop set.Fix: Replace both calls with
asyncio.get_running_loop(), catchingRuntimeErrorwhen no loop is running. This is the correct modern API -- it returns the running loop if one exists, and raises RuntimeError silently (no warning) otherwise.Locations changed:
_pt_safe_print()(~line 1296): cross-thread print path used by background review, curator, and other bg-thread emissions5 new tests in
tests/test_process_loop_event_loop_warning.py, all passing.