fix: add dashboard to CLI help epilogue and Docker CI smoke test#19269
Closed
luoyuctl wants to merge 1 commit into
Closed
fix: add dashboard to CLI help epilogue and Docker CI smoke test#19269luoyuctl wants to merge 1 commit into
luoyuctl wants to merge 1 commit into
Conversation
- Add hermes dashboard examples to the CLI help epilogue so users can discover the web UI command from 'hermes --help' output - Add an independent 'Test dashboard subcommand' CI step that verifies 'hermes dashboard --help' works in the Docker image, with its own mkdir/chown setup to remain independent of the prior smoke test step - Prevents regressions like NousResearch#9153 where the dashboard subcommand was present in source but missing from the published Docker image Closes NousResearch#9153
b9a145e to
0228ec3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #9153 — Docker image missing dashboard command.
The dashboard subparser already exists in the source code, but:
_parser.pydidn't listhermes dashboardexamples, making the command undiscoverable fromhermes --help--helpat the top level, not individual subcommandsChanges
hermes_cli/_parser.py: Addhermes dashboard,hermes dashboard --stop,hermes dashboard --statusexamples to the CLI help epilogue.github/workflows/docker-publish.yml: Add aTest dashboard subcommandstep that runshermes dashboard --helpin the Docker smoke test to prevent future regressionsTest Plan
hermes --helpnow shows dashboard exampleshermes dashboard --helpworks locally