fix(skills): keep manual skills out of curator#19235
Closed
LeonSGP43 wants to merge 1 commit into
Closed
Conversation
Contributor
|
Salvaged and merged via PR #19618 — your commit was cherry-picked with authorship preserved. AUTHOR_MAP updated to credit you on future release notes. Thanks @LeonSGP43! |
This was referenced May 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary\n- require an explicit skill_usage provenance marker before a local skill enters curator reports/transitions\n- mark skills created through skill_manage(action="create") as agent-created for curator eligibility\n- add regression coverage proving manually authored skills with usage records are not auto-archived\n\nFixes #19040\n\n## Testing\n- scripts/run_tests.sh tests/tools/test_skill_usage.py tests/tools/test_skill_manager_tool.py tests/agent/test_curator.py -k 'not curator_slot_is_canonical_aux_task'\n- git diff --check\n\nNote: running the full selected curator file without the -k exclusion also hits an existing local optional dependency failure: tests/agent/test_curator.py::test_curator_slot_is_canonical_aux_task imports hermes_cli.web_server, which exits because fastapi is not installed in this venv.