fix(tui): avoid main-screen scrollback reset loops#19225
Closed
LeonSGP43 wants to merge 1 commit into
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
fullReset(offscreen)inLogUpdate.render.Why
Fixes #19216. After a terminal resize, dynamic rows that have already moved into main-screen scrollback can differ from the virtual frame. Resetting the whole terminal for those invisible rows can immediately perturb scrollback again, causing repeated repaint/flicker and duplicated status-bar lines.
Scope
This is limited to the Hermes Ink diff renderer. It does not change resize handling in the classic CLI or the alt-screen repaint path.
Verification
cd ui-tui && npm test -- --run packages/hermes-ink/src/ink/log-update.test.ts-> 5 passedcd ui-tui && npm run type-checkgit diff --check