fix(docker): refuse root gateway runs in official image#19215
Closed
LeonSGP43 wants to merge 1 commit into
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #18936.
If the official Docker image is started with an overridden entrypoint that bypasses
/opt/hermes/docker/entrypoint.sh,hermes gateway runcan run as root and create root-owned gateway state under/opt/data. That later breaks normal non-root dashboard/gateway runs after the entrypoint is restored.This PR adds a runtime guard before the gateway starts:
/opt/hermes/docker/entrypoint.shin the entrypoint chainHERMES_ALLOW_ROOT_GATEWAY=1escape hatchVerification
scripts/run_tests.sh tests/hermes_cli/test_gateway.py25 passed, 4 warnings