fix(kanban): use get_default_hermes_root() for profile discovery#19030
Closed
shellybotmoyer wants to merge 1 commit into
Closed
fix(kanban): use get_default_hermes_root() for profile discovery#19030shellybotmoyer wants to merge 1 commit into
shellybotmoyer wants to merge 1 commit into
Conversation
list_profiles_on_disk() hardcoded Path.home()/.hermes/profiles, breaking kanban init on custom-root deployments (e.g. HERMES_HOME=/data in Docker). Replaces with get_default_hermes_root()/profiles, consistent with kanban_db_path() and workspaces_root(). Falls back to Path.home()/.hermes/profiles if hermes_constants is unavailable. Fixes NousResearch#19017.
Collaborator
Collaborator
Contributor
|
Closing as duplicate of #19020. Both PRs fixed the same one-line bug in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix: kanban init profile discovery hardcodes
~/.hermes/profilesProblem
list_profiles_on_disk()inkanban_db.pyhardcodedPath.home() / ".hermes" / "profiles", sohermes kanban initalways reported "No profiles found" on custom-root deployments (e.g.,HERMES_HOME=/datain Docker).This is inconsistent with
kanban_db_path()andworkspaces_root(), which were already fixed to useget_hermes_home()in #18985.Solution
Replace the hardcoded path with
get_default_hermes_root() / "profiles", consistent with howkanban_db_path()andworkspaces_root()already resolve paths. Falls back toPath.home() / ".hermes" / "profiles"ifhermes_constantsis unavailable.Testing
HERMES_HOMEoverride) will now correctly discover profiles under the custom rootHERMES_HOMEoverride) behave identically sinceget_default_hermes_root()returnsPath.home() / ".hermes"in that caseFixes #19017