test(acp): pull advertised-commands list from source of truth#18977
Open
Sanjays2402 wants to merge 1 commit into
Open
test(acp): pull advertised-commands list from source of truth#18977Sanjays2402 wants to merge 1 commit into
Sanjays2402 wants to merge 1 commit into
Conversation
`HermesACPAgent._ADVERTISED_COMMANDS` was extended with `steer` and
`queue` (between `compact` and `version`), but
`test_send_available_commands_update` still hardcoded the old 7-name
list, so it failed:
AssertionError: assert ['help', 'mod...compact', ...] == ['help', 'mod...compact', ...]
Read the expected name list from
`HermesACPAgent._ADVERTISED_COMMANDS` directly so the assertion
follows the registered command set rather than drifting whenever
commands are added.
The behavioural assertion (`session_update` is awaited once with the
right session id, returns an `AvailableCommandsUpdate`, and
`model`'s input hint is intact) is preserved.
No production code change. Fixes the failure observed on `main`
(run 25250051126):
`tests/acp/test_server.py::TestSessionOps::test_send_available_commands_update`
This was referenced May 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes one
Testsfailure observed onmain(and therefore propagating to every open PR):Reference run: 25250051126 on
5d3be898a.Root cause
HermesACPAgent._ADVERTISED_COMMANDSwas extended withsteerandqueue(betweencompactandversion), but the test still hardcoded the old 7-name list:…so any update that added a command failed the assertion even though the agent was behaving correctly.
Fix
Pull the expected name list from
HermesACPAgent._ADVERTISED_COMMANDSdirectly:The behavioural assertions the test actually cares about (
session_updateis awaited once with the right session id, returns anAvailableCommandsUpdate,model's input hint is intact) are preserved.Validation
Scope
Out of scope
The other ~12 main-CI failures — happy to send those as separate focused PRs (#18972, #18974 already up).