fix(delegate): read delegation config from disk first to avoid stale cache#18967
Closed
Thatgfsj wants to merge 1 commit into
Closed
fix(delegate): read delegation config from disk first to avoid stale cache#18967Thatgfsj wants to merge 1 commit into
Thatgfsj wants to merge 1 commit into
Conversation
…cache _load_config() checked the runtime cache (cli.CLI_CONFIG) first and never fell back to disk when the cache existed. This meant `hermes config set delegation.model <X>` wrote to disk correctly but the running process continued using the old value. Reverse the priority: always read from the persistent config file first, falling back to CLI_CONFIG only when the disk read fails. This makes delegation.* changes take effect immediately without requiring a process restart. Fixes NousResearch#18946
Collaborator
Collaborator
|
Likely duplicate of #18947 — same root cause: _load_config() in delegate_tool.py reads stale CLI_CONFIG cache instead of disk. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #18946
_load_config()intools/delegate_tool.pychecked the runtime cache (cli.CLI_CONFIG) first and never fell back to disk when the cache existed. This meanthermes config set delegation.model <X>wrote to disk correctly but the running process continued using the old value silently.Changes
Reverse the priority in
_load_config(): always read from the persistent config file first, falling back toCLI_CONFIGonly when the disk read fails. This makesdelegation.*changes take effect immediately without requiring a process restart.Test plan