fix(skills): exclude hidden dirs from skill search, guard cyclic symlinks, handle non-dict quick_commands#18937
Open
oluwadareab12 wants to merge 1 commit into
Conversation
…inks, handle non-dict quick_commands (NousResearch#18900, NousResearch#18809, NousResearch#18816)
dd19686 to
147ab9e
Compare
This was referenced May 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #18900, #18809, #18816
#18900 -- _find_skill rglob leaks into .archive, .git, .github, .hub
Replace bare rglob in _find_skill with iter_skill_index_files which already excludes those dirs.
#18809 -- os.walk(followlinks=True) infinite-loop on cyclic symlinks
Add seen-inode tracking to iter_skill_index_files. If a directory inode pair has already been visited the subtree is pruned. Non-cyclic symlinks are still followed.
#18816 -- quick_commands with non-dict values crashes slash command dispatch
Add isinstance(qcmd, dict) guard in both gateway/run.py and cli.py before calling .get(). Misconfigured entries return a clear error message instead of crashing with AttributeError.
14 new tests in tests/test_skill_rglob_and_quick_commands.py, all passing.