fix(cli): guard quick_commands against non-dict values#18817
Closed
shellybotmoyer wants to merge 1 commit into
Closed
fix(cli): guard quick_commands against non-dict values#18817shellybotmoyer wants to merge 1 commit into
shellybotmoyer wants to merge 1 commit into
Conversation
Fixes NousResearch#18816. Add isinstance guard before qcmd.get() to prevent crash when quick_commands values are strings or other non-dict types.
Contributor
Author
|
Superseded by #18850 which has the more complete fix with parity checks across CLI and gateway. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix: Guard
quick_commandsagainst non-dict valuesProblem
When
quick_commandsvalues in~/.hermes/config.yamlare not dicts (e.g., strings likefoo: ''), the slash command dispatch atcli.py:6583crashes with:This blocks all matching slash commands — even valid skill commands — because
quick_commandsis checked before the skill dispatch chain.Reproduction
Then type
/foo— crash.Fix
Add
isinstance(qcmd, dict)guard before accessing.get(). Non-dict entries now get a warning log and fall through to plugin/skill command checks instead of crashing.Fixes #18816