fix(skills): prevent infinite loop on cyclic symlinks in iter_skill_index_files#18815
Open
liuhao1024 wants to merge 2 commits into
Open
fix(skills): prevent infinite loop on cyclic symlinks in iter_skill_index_files#18815liuhao1024 wants to merge 2 commits into
liuhao1024 wants to merge 2 commits into
Conversation
…ndex_files os.walk(followlinks=True) can loop forever when the skill directory tree contains cyclic symlinks (e.g. A→B→A or self-referencing dirs). Track visited real paths via os.path.realpath() and skip directories whose canonical path has already been processed. Non-cyclic symlinks are still followed as before. Fixes NousResearch#18809
Collaborator
1 similar comment
Collaborator
- Add sunsky.lau@gmail.com to AUTHOR_MAP for check-attribution CI - Use resolve() in test_cyclic_symlink_does_not_loop since os.walk traversal order varies by platform (macOS alphabetical vs Linux hash)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
iter_skill_index_files()usesos.walk(followlinks=True)but has no cycle detection. When the skill directory tree contains cyclic symlinks (e.g.A → B → Aor self-referencing directories),os.walkenters an infinite loop, causing the agent to hang during skill scanning.Related Issue
Fixes #18809
Type of Change
Changes Made
How to Test
pytest tests/ -q— all tests should passChecklist
Code
fix(scope):,feat(scope):, etc.)pytest tests/ -qand all tests passDocumentation & Housekeeping
docs/, docstrings) — or N/Acli-config.yaml.exampleif I added/changed config keys — or N/ACONTRIBUTING.mdorAGENTS.mdif I changed architecture and workflows — or N/A