fix(skills): preserve command cache on scan setup failure#18668
Open
LeonSGP43 wants to merge 1 commit into
Open
fix(skills): preserve command cache on scan setup failure#18668LeonSGP43 wants to merge 1 commit into
LeonSGP43 wants to merge 1 commit into
Conversation
Contributor
|
Closed my competing PR (#22514) in favor of this one — same swap-on-success pattern for |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_skill_commandsmapping available when scan setup or directory traversal failsFixes #18659.
Verification
scripts/run_tests.sh tests/agent/test_skill_commands.py::TestScanSkillCommands::test_preserves_cached_commands_when_scan_setup_fails tests/agent/test_skill_commands.pygit diff --check origin/main...HEADOverlap check