fix(delegation): respect delegation.model config for subagents (fixes #12440)#18649
Closed
GregChinn wants to merge 1 commit into
Closed
fix(delegation): respect delegation.model config for subagents (fixes #12440)#18649GregChinn wants to merge 1 commit into
GregChinn wants to merge 1 commit into
Conversation
…esearch#12440) - Add delegation_cfg.get('model') to effective_model resolution at lines 946 and 982 - Subagents now properly inherit the model specified in delegation.model config - Previously ignored delegation.model, always falling back to parent agent model - Fixes GitHub issue NousResearch#12440
Collaborator
Collaborator
|
Likely duplicate of #12503 |
Contributor
|
Thanks for the contribution. This behavior is already implemented on current Automated hermes-sweeper review evidence:
The prior maintainer comments noting this was likely duplicate work were consistent with the current code. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #12440 - Subagents were ignoring the
delegation.modelconfig setting and always inheriting the parent agent's model.Changes
delegation_cfg.get("model")to the model resolution chain at lines 946 and 982 intools/delegate_tool.pydelegation.modelconfig > parent agent modelTesting
Manually verified that subagents now use the model specified in
delegation.modelin config.yaml instead of always inheriting the parent model.Related