fix: use extract_content_or_reasoning() for title generation with reasoning models#18643
Open
Kailigithub wants to merge 1 commit into
Open
fix: use extract_content_or_reasoning() for title generation with reasoning models#18643Kailigithub wants to merge 1 commit into
Kailigithub wants to merge 1 commit into
Conversation
84fb751 to
707477e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
auxiliary.title_generationuses a reasoning model (MiniMax-M2.7, DeepSeek-R1, Qwen-QwQ, etc.), the auto-generated session title is empty because the code readsresponse.choices[0].message.contentdirectly — which isNonewhen the model returns content via structured reasoning fields instead of.content.Fix: Replace the direct
.message.contentaccess with the existingextract_content_or_reasoning()helper that already handles reasoning models correctly. This is the same pattern used insession_search_tool.py,web_tools.py, andvision_tools.py.Changes:
extract_content_or_reasoningto the import fromagent.auxiliary_clientresponse.choices[0].message.contentwithextract_content_or_reasoning(response)Verification:
py_compilepassesCloses #18529