fix(feishu): preserve reply context from root_id#18567
Open
CNSeniorious000 wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #18566.
Summary
Treat Feishu/Lark
root_idas a fallback inbound reply target afterparent_idandupper_message_id.Avoid treating a message as replying to itself when
root_idequals the currentmessage_id.Add Feishu adapter regression coverage for parent-id, root-id-only, and self-root reply context handling.
Add the commit author's
AUTHOR_MAPentry so the contributor audit can pass once fork workflows are approved.Scope
This PR is limited to inbound reply-to context: it only uses
root_idas a fallback forMessageEvent.reply_to_message_id. It does not change outbound Feishu topic/thread routing orsource.thread_idbehavior, which are covered separately by #16131 and #8656.Test Plan
uv run pytest tests/gateway/test_feishu.py -q -o 'addopts=' uv run python scripts/contributor_audit.py --since-tag v2026.4.30 --diff-base origin/main --strictReview
Codex read-only correctness review: no blockers.
Codex simplify/atomicity review: no blockers; confirmed no interactive-card changes.
CI
GitHub Actions are currently
ACTION_REQUIREDfor this fork PR and need maintainer approval before running.