fix(profiles,kanban): normalize profile IDs for assignees and CLI paths (#18498)#18518
Closed
changchun989 wants to merge 1 commit into
Closed
Conversation
- Add normalize_profile_name() for lowercase canonical IDs and Default alias - Use canonical names in create/delete/rename/export/import/set_active paths - Canonicalize Kanban assignee on create/assign, list filter, and worker spawn - Tests for mixed-case assignees and profile resolution (fixes NousResearch#18498)
Collaborator
Collaborator
This was referenced May 4, 2026
Contributor
|
Closing as already-merged. This PR was salvaged via PR #19700 on May 4 with your commit A small follow-up cleanup landed shortly after as commit Looks like this PR just got left open after the salvage 6 days ago — sorry about that. Thanks @changchun989! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
normalize_profile_name()so profile identifiers are canonical (lowercase on disk;defaultmatched case-insensitively).set_active_profile,resolve_profile_env, and wrapper/alias helpers through the canonical id to avoid mixed-case footguns (e.g. treatingDefaultas a new profile).assigneeon task create/assign and inlist_tasks(..., assignee=...);_default_spawnpasses normalized-p/HERMES_PROFILEso gateway dispatch matches dashboard/title-case labels.Fixes #18498
Test plan
python -m pytest tests/hermes_cli/test_profiles.py tests/hermes_cli/test_kanban_db.py -q -n 0 -o addopts=