fix(transports): set temperature and parallel_tool_calls for custom chat_completions#18489
Open
wpengpeng168 wants to merge 1 commit into
Open
Conversation
…hat_completions Apply a conservative default sampling temperature when the transport runs in is_custom_provider mode with no fixed_temperature, matching local OpenAI stacks that implicitly use 1.0. When tools are present on the same route, default parallel_tool_calls so multi-tool turns can batch. Add regression tests for custom-provider kwargs. Fixes NousResearch#18470.
Collaborator
Collaborator
|
Likely duplicate of #18483 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Hermes forwards
provider == "custom"through the Chat Completions transport. Those stacks often default omittedtemperatureto1.0and omitparallel_tool_calls, which forces sequential tool rounds even when the server supports parallel tool calls.Fill in a conservative sampling default when Hermes supplies neither
omit_temperaturenorfixed_temperature, and mirror the Codex transport default by allowing parallel tool batches when tools are present.Changes
agent/transports/chat_completions.py: custom-provider temperature default + parallel tool calls when tools exist.tests/agent/transports/test_chat_completions.py: regression coverage.Verification