fix(acp): pass fallback_providers to AIAgent (parity with CLI)#18460
Open
xyiy001 wants to merge 1 commit into
Open
fix(acp): pass fallback_providers to AIAgent (parity with CLI)#18460xyiy001 wants to merge 1 commit into
xyiy001 wants to merge 1 commit into
Conversation
ACP adapter previously omitted the configured provider fallback chain, so editors using ACP never failed over like CLI/Gateway. Align config normalization with HermesCLI (fallback_providers and legacy fallback_model dict).
23 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The ACP adapter built
AIAgentwithout wiring the configured provider fallback chain, so clients (Obsidian ACP, VS Code, JetBrains, Zed, etc.) never failed over when the primary model errored. CLI and gateway already pass this viafallback_model/fallback_providers.This change reads
fallback_providers(and legacyfallback_model) from the loaded Hermes config, applies the same dict→list normalization asHermesCLI, and passes the result asfallback_model=intoAIAgent.Closes #18452
Test plan
pytest tests/acp/test_session.py::TestMakeAgentPassesFallbackProviders -q -o addopts=