fix(gateway): respect explicit Telegram disabled when TELEGRAM_BOT_TOKEN is set#18418
Open
keiravoss94 wants to merge 1 commit into
Open
Conversation
9031fe4 to
f8aae15
Compare
Mirror Slack: TELEGRAM_BOT_TOKEN no longer forces enabled when config sets telegram.enabled or platforms.telegram.enabled to false. Token remains available for tools. Add regression tests.
f8aae15 to
72e7510
Compare
This was referenced May 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Telegram matched Slack's bug:
TELEGRAM_BOT_TOKENalways forcedenabled: true, sotelegram.enabled: false/platforms.telegram.enabled: falsewas ignored. This mirrors the existing Slack_enabled_explicitpattern so users can keep the token for tools/cron while leaving the gateway adapter off.Related Issue
Fixes #
Type of Change
Changes Made
gateway/config.py— tagplatforms.telegram/ top-leveltelegram.enabledas explicit like Slack; only auto-enable from env token when disable was not explicittests/gateway/test_config.py— regression tests for explicit Telegram disable with token presentHow to Test
uv run pytest -o addopts= tests/gateway/test_config.py -k telegram -qTELEGRAM_BOT_TOKENandplatforms.telegram.enabled: falsein config — confirm the Telegram gateway adapter does not startChecklist
Code
fix(scope):,feat(scope):, etc.)pytest tests/ -qand all tests passDocumentation & Housekeeping
docs/, docstrings) — or N/Acli-config.yaml.exampleif I added/changed config keys — or N/ACONTRIBUTING.mdorAGENTS.mdif I changed architecture or workflows — or N/AFor New Skills
N/A — delete this section otherwise.
Screenshots / Logs
N/A