fix(tui): preserve fallback provider chain#18310
Conversation
|
This is a small TUI parity fix: it preserves configured fallback provider chains when agents are constructed through the TUI gateway path. Local targeted test: tests/test_tui_gateway_server.py, 164 passed. |
d60ba28 to
a84ed03
Compare
|
Status update after refresh:
No further code changes were made beyond keeping the branch current with upstream main. |
4820f11 to
1ed7103
Compare
|
Refreshed again against current
No code changes beyond rebasing the existing fix over current main. |
1ed7103 to
cc89de5
Compare
|
Refreshed again against current
Local verification:
No functional scope changes were made beyond rebasing the existing fix over current main. |
cc89de5 to
8b878e7
Compare
|
Refreshed against current
Local verification:
|
|
Final pre-merge review from Hermes Agent:
Verdict: no blockers found; ready for maintainer merge. |
8b878e7 to
d7ecb28
Compare
|
Refreshed against current
No functional scope change intended beyond rebasing the existing fallback-provider-chain fix onto current upstream. |
d7ecb28 to
825c3eb
Compare
|
Refreshed against current main. Current head: Local verification:
Result: No CI checks are reported by GitHub for this PR at the moment. |
825c3eb to
e8cce7f
Compare
|
Refreshed against current
Local verification:
No intentional functional scope change beyond refreshing the existing fallback-provider-chain fix onto current upstream. |
e8cce7f to
4814d9c
Compare
|
Refreshed again against latest
Local verification:
No intentional functional scope change beyond refreshing the existing TUI fallback-provider-chain fix onto current upstream. |
f999731 to
c62c4f0
Compare
085b220 to
4b73a4c
Compare
4b73a4c to
67b51ac
Compare
|
Maintainer handoff / refresh status:
No further action needed from my side unless |
67b51ac to
9e92529
Compare
9e92529 to
4f0b534
Compare
|
Refreshed this PR onto current upstream Verification:
Note: an initial CI run hit an unrelated transient Chrome/browser-supervisor timeout in |
Summary
AIAgentinstances.fallback_providers/ legacyfallback_modelin the TUI gateway path and pass the resulting chain through_make_agent()._fallback_chainwhen cloning background agents, including the explicitly empty-chain case.Problem
TUI-created agents did not reliably receive the configured fallback provider chain. Classic CLI / gateway paths could fail over, while the TUI path could lose or reduce the chain during agent construction or background-agent cloning.
Fix
fallback_model=_load_fallback_model()intoAIAgentconstruction intui_gateway/server.py._fallback_chainwhen building background-agent kwargs, rather than reducing the configuration to a single fallback model.Tests
tests/test_tui_gateway_server.py: 172 passedLatest local verification after rebasing onto current
origin/main: