fix(agent): default MiniMax provider to anthropic_messages + correct base_url#18147
Open
nicoechaniz wants to merge 3 commits into
Open
fix(agent): default MiniMax provider to anthropic_messages + correct base_url#18147nicoechaniz wants to merge 3 commits into
nicoechaniz wants to merge 3 commits into
Conversation
6e43238 to
1ab7705
Compare
…base_url PR NousResearch#17425 (merged) enabled prompt caching for MiniMax models on the anthropic_messages transport, but users still had to manually configure both api_mode and base_url to actually benefit from it. This patch makes the defaults ergonomic: - AIAgent.__init__ now auto-detects provider=minimax / minimax-cn and defaults to api_mode=anthropic_messages + the correct /anthropic base_url (global or China endpoint respectively). - .env.example suggests the /anthropic endpoints instead of /v1. - Explicit base_url or api_mode are preserved when the user sets them. Tests: 5 new cases covering both providers, explicit overrides, and prompt-caching flags. Refs: NousResearch#17332, NousResearch#17333, NousResearch#17425
1ab7705 to
6cc22c6
Compare
…rsing when uncommented
…roviderConfig.inference_base_url handles it now
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR #17425 enabled prompt caching for MiniMax models on the transport, but users still had to manually configure both and to actually benefit from it.
This patch makes the defaults ergonomic:
Tests: 5 new cases covering both providers, explicit overrides, and prompt-caching flags.
Refs: