fix(cron): restore profile binding and harden origin-local delivery#18120
Closed
caspiannacht-sudo wants to merge 2 commits into
Closed
fix(cron): restore profile binding and harden origin-local delivery#18120caspiannacht-sudo wants to merge 2 commits into
caspiannacht-sudo wants to merge 2 commits into
Conversation
Treat origin-less deliver=origin jobs as local-only, including legacy list-form values. Harden bound-home child-result temp-file setup so filesystem failures return structured cron failure tuples. Align cron tests with run_job dispatcher behavior, isolate tick lock paths in tests, and add regression coverage for bound-home tempfile setup failure.
Collaborator
|
Likely duplicate of #14703 — same cron profile binding + website hardening work, rebased onto current main. |
Author
|
Closing this as superseded by PR #14703. I have force-updated the #14703 source branch ( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
maindeliver=originas local-only instead of falling back to ambient home-channel configurationrun_job()dispatcher model and current upstreammainWhy this PR replaces the earlier branch
origin/mainChanges
cron/profile binding + unattended website hardening
profile/hermes_homebinding in cron job definitions and runtime resolutionorigin-less delivery and bound-home result hardening
deliver=originresolutiondeliverhandling inside delivery logictest alignment
Verification
venv/bin/python -m pytest tests/cron tests/tools/test_website_policy_strict.py tests/test_hermes_constants.py -q -o 'addopts='296 passedvenv/bin/python -m py_compile cron/scheduler.py tests/cron/test_scheduler.py tests/cron/test_cron_workdir.py tests/cron/test_codex_execution_paths.py tests/cron/test_cron_script.py tests/test_hermes_constants.py tools/cronjob_tools.py tools/website_policy.py hermes_constants.py