fix(cli): resolve runtime credentials for current model#17590
Closed
liuhao1024 wants to merge 1 commit into
Closed
fix(cli): resolve runtime credentials for current model#17590liuhao1024 wants to merge 1 commit into
liuhao1024 wants to merge 1 commit into
Conversation
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/modelswitches that require a non-defaultapi_mode.Root cause
HermesCLI._ensure_runtime_credentials()re-resolved provider credentials without passing the active model. Providers whose transport depends on the selected model could therefore recomputeapi_modefrom stale persisted config instead of the current/modelselection.Fix
Forward
target_model=self.modelduring normal runtime resolution andtarget_model=_fb_modelwhen falling through to an auth fallback.Regression coverage
Added
tests/cli/test_runtime_credentials.pyto assert that_ensure_runtime_credentials()passes the active model toresolve_runtime_provider()and invalidates the cached agent when routing changes.Testing
scripts/run_tests.sh tests/cli/test_runtime_credentials.py -qscripts/run_tests.sh tests/cli/test_runtime_credentials.py tests/hermes_cli/test_runtime_provider_resolution.py -qCloses #17574