Fix delegate_task model/provider precedence and expose per-task overrides#17581
Open
afurm wants to merge 1 commit into
Open
Fix delegate_task model/provider precedence and expose per-task overrides#17581afurm wants to merge 1 commit into
afurm wants to merge 1 commit into
Conversation
This was referenced May 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fix delegation so
delegate_taskconsistently applies model/provider override precedence across top-level and per-task configuration, and forwards the resolved credentials to child agents. This resolves cases where users passmodel/providerbut child tasks still use unintended defaults.Also updates the tool schema and tests to document and verify the new behavior.
Related Issue
Fixes #10995
Type of Change
Changes Made
modelandproviderargs todelegate_taskin tools/delegate_tool.py.model/providermodel/providerdelegation.model/delegation.providerfrom configmodel,override_provider,override_base_url,override_api_key,override_api_mode) in tools/delegate_tool.py.DELEGATE_TASK_SCHEMAwith:model,providertasks[].model,tasks[].providerTestDelegateRequirements.test_schema_validnow checks new schema fields.test_top_level_model_provider_overridesvalidates top-level propagation.test_per_task_model_provider_overridevalidates per-task precedence over top-level values.How to Test
scripts/run_tests.sh tests/tools/test_delegate.pyscripts/run_tests.sh -k "model_provider_override"Checklist
Code
fix(scope):,feat(scope):, etc.)pytest tests/ -qand all tests passDocumentation & Housekeeping
docs/, docstrings) — or N/Acli-config.yaml.exampleif I added/changed config keys — or N/ACONTRIBUTING.mdorAGENTS.mdif I changed architecture or workflows — or N/A