feat(yuanbao): wire native text + media delivery into send_message#17424
Merged
Conversation
_send_yuanbao() already supported media_files= and the user-facing error strings already advertised yuanbao support, but there was no dispatch branch in _send_to_platform() actually routing to it. Target yuanbao in send_message previously fell through to "Direct sending not yet implemented". - Add yuanbao media-chunk branch (mirrors Signal/Matrix: media on final chunk only). - Add yuanbao elif in the non-media loop. Salvage of #17411; SKILL.md description change and redundant sidebars.ts entry dropped, indentation/trailing-whitespace cleaned up.
Open
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Wires the existing
_send_yuanbao()helper into_send_to_platform()sosend_messagetargeting yuanbao actually works — both text-only and media-attached chunks.Before this,
_send_yuanbao()already acceptedmedia_files=and the user-facing error strings already claimed yuanbao was supported, but no dispatch branch actually routed to it. Text-only yuanbao sends fell through to"Direct sending not yet implemented".Changes
tools/send_message_tool.py: yuanbao media-chunk branch (mirrors Signal/Matrix — attachments on the final chunk only) +elif Platform.YUANBAOdispatch in the non-media loop.Validation
send_message target="yuanbao:..."text{error: "Direct sending not yet implemented for yuanbao"}_send_yuanbaosend_messagewithmedia_filespy_compileSalvage of #17411 by @LoongZhao. SKILL.md description change and redundant
website/sidebars.tsentry (already on main) dropped; indentation + trailing-whitespace cleaned up.