fix(memory): warn when holographic memory lacks numpy#17356
Open
samrusani wants to merge 1 commit into
Open
Conversation
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
numpy, instead of silently degrading HRR-backed retrievalhermes doctorwhenmemory.provider: holographicis activeWhy
Fixes #17350. Without
numpy, holographic memory still registers and stores facts, but semantic HRR behavior is disabled or downgraded:probe/related/reasonfall back to keyword search, andcontradictreturns no results. Users had no visible signal that this was happening.Testing
./.venv/bin/python -m pytest -o addopts='' tests/agent/test_memory_provider.py::TestPluginMemoryDiscovery::test_holographic_warns_when_numpy_missing tests/hermes_cli/test_doctor.py::TestDoctorMemoryProviderSection::test_holographic_provider_warns_when_numpy_missing -q./.venv/bin/python -m pytest -o addopts='' tests/agent/test_memory_provider.py -q./.venv/bin/python -m pytest -o addopts='' tests/hermes_cli/test_doctor.py -q./.venv/bin/python -m py_compile plugins/memory/holographic/__init__.py hermes_cli/doctor.py tests/agent/test_memory_provider.py tests/hermes_cli/test_doctor.pyNote: running
tests/agent/test_memory_provider.py tests/hermes_cli/test_doctor.pytogether still exposes an existing order-dependent failure in two Honcho doctor tests that monkeypatchplugins.memory.honchoafterplugins.memoryhas already been imported. Each file passes independently.