Skip to content

fix(memory): warn when holographic memory lacks numpy#17356

Open
samrusani wants to merge 1 commit into
NousResearch:mainfrom
samrusani:fix/holographic-numpy-degraded-warning
Open

fix(memory): warn when holographic memory lacks numpy#17356
samrusani wants to merge 1 commit into
NousResearch:mainfrom
samrusani:fix/holographic-numpy-degraded-warning

Conversation

@samrusani

@samrusani samrusani commented Apr 29, 2026

Copy link
Copy Markdown

Summary

  • warn once when the holographic memory provider initializes without numpy, instead of silently degrading HRR-backed retrieval
  • surface the same degraded state in hermes doctor when memory.provider: holographic is active
  • add focused regression coverage for provider initialization and doctor diagnostics

Why

Fixes #17350. Without numpy, holographic memory still registers and stores facts, but semantic HRR behavior is disabled or downgraded: probe / related / reason fall back to keyword search, and contradict returns no results. Users had no visible signal that this was happening.

Testing

  • ./.venv/bin/python -m pytest -o addopts='' tests/agent/test_memory_provider.py::TestPluginMemoryDiscovery::test_holographic_warns_when_numpy_missing tests/hermes_cli/test_doctor.py::TestDoctorMemoryProviderSection::test_holographic_provider_warns_when_numpy_missing -q
  • ./.venv/bin/python -m pytest -o addopts='' tests/agent/test_memory_provider.py -q
  • ./.venv/bin/python -m pytest -o addopts='' tests/hermes_cli/test_doctor.py -q
  • ./.venv/bin/python -m py_compile plugins/memory/holographic/__init__.py hermes_cli/doctor.py tests/agent/test_memory_provider.py tests/hermes_cli/test_doctor.py

Note: running tests/agent/test_memory_provider.py tests/hermes_cli/test_doctor.py together still exposes an existing order-dependent failure in two Honcho doctor tests that monkeypatch plugins.memory.honcho after plugins.memory has already been imported. Each file passes independently.

@alt-glitch alt-glitch added type/bug Something isn't working P3 Low — cosmetic, nice to have comp/plugins Plugin system and bundled plugins comp/cli CLI entry point, hermes_cli/, setup wizard tool/memory Memory tool and memory providers labels Apr 29, 2026
@samrusani samrusani marked this pull request as ready for review April 29, 2026 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp/cli CLI entry point, hermes_cli/, setup wizard comp/plugins Plugin system and bundled plugins P3 Low — cosmetic, nice to have tool/memory Memory tool and memory providers type/bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Holographic memory silently degrades to FTS5-only when numpy is missing — no warning, no error, no doctor detection

2 participants