fix(tui): avoid creating chat sessions on dashboard mount#17128
Open
nova-celestials-sh wants to merge 4 commits into
Open
fix(tui): avoid creating chat sessions on dashboard mount#17128nova-celestials-sh wants to merge 4 commits into
nova-celestials-sh wants to merge 4 commits into
Conversation
54d1d82 to
498a4e3
Compare
4 tasks
Collaborator
|
Complementary to #18370 (backend lazy creation). This PR handles the frontend/TypeScript side. Both can merge independently. |
Author
|
@alt-glitch conflicts are resolved and the branch is ready for merge. Verification:
GitHub now reports the PR as mergeable. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
session.infoeventsWhy
Opening the dashboard Chat page currently creates empty
source=tuirows even when the user is only browsing. In the dashboard this makes the session list noisy and makes resuming real conversations harder. Session persistence should happen when a conversation begins, not when the route renders.How to test
hermes dashboard --host 127.0.0.1 --port 9119 --tui --no-open/chatwithout sending a prompt.source=tuisession row is persisted.Platforms tested
Verification
npm run type-check --prefix ui-tuinpm test --prefix ui-tui -- createGatewayEventHandlernpm run build --prefix webHERMES_HOMEdashboard with--tui, loaded/chatin Chromium, and confirmedstate.dbstill had0sessions /0empty TUI sessions after page load.Full test suite note
./venv/bin/pytest tests/ -v104 failed, 17249 passed, 52 skipped, 210 warnings, 1 error in 174.86stests/gateway/test_session.py(normalize_whatsapp_identifiermissing fromgateway.session).