Fix/lmstudio runtime resolution fork2#17072
Closed
syukouyuu wants to merge 7 commits into
Closed
Conversation
…ass provider status
- Implements Authorization Code + PKCE (S256) flow with localhost callback - Stores credentials in HERMES_HOME/gemini_oauth.json - Supports Gemini API token refresh
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes an issue where LM Studio local endpoints were not consistently resolving through the custom-provider runtime path.
In the failing cases, LM Studio-style local providers could miss the intended custom-provider path and behave like generic custom/OpenRouter fallbacks. This could cause:
LM_STUDIO_*env vars not being honored reliably.Related Issue
Fixes #12146 #4172
Type of Change
Changes Made
lm-studio/lmstudioaliases during runtime provider resolution (hermes_cli/runtime_provider.py).LM_STUDIO_BASE_URLandLM_STUDIO_API_KEYfor local LM Studio endpoints.OPENROUTER_API_KEY.tests/hermes_cli/test_runtime_provider_resolution.py).How to Test
pytest tests/hermes_cli/test_runtime_provider_resolution.py -qlm-studio/lmstudiopass successfully.LM_STUDIO_BASE_URLpass and ensure local endpoints do not fall back toOPENROUTER_API_KEY.Checklist
Code
fix(scope):,feat(scope):, etc.)pytest tests/ -qand all tests passDocumentation & Housekeeping
docs/, docstrings) — or N/Acli-config.yaml.exampleif I added/changed config keys — or N/ACONTRIBUTING.mdorAGENTS.mdif I changed architecture or workflows — or N/AScreenshots / Logs
(N/A)