Skip to content

fix(send_message): enable Feishu media attachments (images/video/docs)#16920

Closed
hillerliao wants to merge 1 commit into
NousResearch:mainfrom
hillerliao:fix/feishu-media-attachments-v2
Closed

fix(send_message): enable Feishu media attachments (images/video/docs)#16920
hillerliao wants to merge 1 commit into
NousResearch:mainfrom
hillerliao:fix/feishu-media-attachments-v2

Conversation

@hillerliao

@hillerliao hillerliao commented Apr 28, 2026

Copy link
Copy Markdown

Problem

The _send_feishu call was missing the media_files argument, causing all MEDIA:path attachments to be silently dropped for Feishu targets — despite FeishuAdapter fully supporting send_image_file / send_document / send_video.

Feishu was also missing from the supported-platforms list in the warning/error messages.

Fix

  1. Pass media_files=media_files to _send_feishu so image/document/video attachments actually reach the adapter.
  2. Add Feishu to the supported-platforms list in the media-only error and warning messages.

Testing

87 tests pass in test_send_message_tool.py. Live Feishu DM confirmed working.

fix(send_message): enable Feishu media attachments (images/video/docs)
553f9b9 
Pass media_files to _send_feishu so images/videos/docs actually
reach the FeishuAdapter instead of being silently dropped.
Also moves Feishu to the supported-platforms list in the warning
and error messages.
@alt-glitch alt-glitch added type/bug Something isn't working P2 Medium — degraded but workaround exists platform/feishu Feishu / Lark adapter comp/tools Tool registry, model_tools, toolsets labels Apr 28, 2026
@alt-glitch alt-glitch mentioned this pull request Apr 28, 2026
Closed
@tipani86

tipani86 commented Apr 29, 2026

Copy link
Copy Markdown

Tested the same fix path locally in a Feishu DM: routing MEDIA: attachments through _send_feishu(..., media_files=...) successfully delivered Markdown files as native Feishu attachments. +1 for getting this merged.

@de1tydev

de1tydev commented Apr 29, 2026

Copy link
Copy Markdown

I rechecked this against current main and the issue still appears to be present: the Feishu dispatch path still calls _send_feishu(pconfig, chat_id, chunk, thread_id=thread_id) without passing media_files.

Impact: Feishu send_message calls containing MEDIA:/path can either drop the attachment while returning text success, or hit the generic media-unsupported branch for media-only messages. That is user-visible for generated images/docs/Markdown files because the agent may claim delivery while the actual file never reaches Feishu.

The fix in this PR is still the right narrow fix path:

  • pass media_files=media_files into _send_feishu(...)
  • treat Feishu as media-capable in the media-only / warning branches

I could not edit the PR body from this account, so leaving the current-status note here for reviewer context.

@alt-glitch alt-glitch mentioned this pull request Apr 30, 2026
Open
@teknium1

teknium1 commented May 5, 2026

Copy link
Copy Markdown
Contributor

Closing as superseded — @yuehei's PR landed the same _send_feishu(..., media_files=media_files, ...) wiring and supported-platforms-list update independently (commit cdde0c8, "fix(feishu): enable MEDIA attachment delivery in send_message tool", May 3). Thanks for the contribution — the fix is in main.

@teknium1 teknium1 closed this May 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

comp/tools Tool registry, model_tools, toolsets P2 Medium — degraded but workaround exists platform/feishu Feishu / Lark adapter type/bug Something isn't working

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@hillerliao @tipani86 @de1tydev @teknium1 @alt-glitch