feat(gateway): add text-only Microsoft Teams adapter#16639
Closed
gianfrancopiana wants to merge 1 commit into
Closed
feat(gateway): add text-only Microsoft Teams adapter#16639gianfrancopiana wants to merge 1 commit into
gianfrancopiana wants to merge 1 commit into
Conversation
cadcdc2 to
580c94d
Compare
This was referenced Apr 30, 2026
Contributor
|
Thanks for this contribution, @gianfrancopiana! After reviewing current Evidence:
The plugin approach is architecturally preferable to this PR's hardcoded-in-core approach, and already covers the full feature set planned across your steps 1–3 (text core, setup/status, rich features including Adaptive Cards). Closing as implemented on main. This is an automated hermes-sweeper review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
msteamsinto gateway config, allowlists, platform/toolset metadata, prompt hints, status, and docs.Why
This is step 1 of a smaller Teams PR series: land the secure text core first, then build on it.
The existing Teams work in #13767 is useful, but it is a large ~6.3k-addition / 34-file PR, which makes review harder. This PR keeps the first slice smaller and reviewable instead of asking reviewers to take Graph, files, cards, docs, and gateway plumbing all at once.
Planned follow-ups:
serviceUrlbehavior and fuller docs.Related: #9512, #13767.
Tests
python -m pytest -q tests/gateway/test_msteams_adapter.py tests/gateway/test_msteams_auth.py tests/gateway/test_msteams_config.py tests/gateway/test_config.py tests/gateway/test_config_cwd_bridge.py tests/hermes_cli/test_config.py tests/hermes_cli/test_tools_config.py tests/hermes_cli/test_config_drift.pypython -m ruff check gateway/platforms/msteams tests/gateway/test_msteams_adapter.py tests/gateway/test_msteams_auth.py tests/gateway/test_msteams_config.pyNote: I also tried
python -m pytest tests/ -q. In this local checkout it does not complete; with-x --tb=shortit stops during collection on an existingorigin/mainPython 3.11 syntax error intests/tools/test_dockerfile_pid1_reaping.py:42, which this PR does not touch.