fix(gateway): ignore MEDIA examples without local files#16436
Open
qwertysc wants to merge 1 commit into
Open
Conversation
This was referenced May 8, 2026
This was referenced May 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
MEDIA:tags inside fenced code blocks and inline code.MEDIA:paths for native delivery when the expanded local file exists.MEDIA:examples in text instead of removing them or attempting delivery.Root cause
BasePlatformAdapter.extract_media()treated anyMEDIA:<path>token as a real attachment directive. Code snippets, grep output, and test examples containingMEDIA:/tmp/missing.pngwere therefore sent through native media delivery and produced noisyFile not foundwarnings.What changed
os.path.isfile()before adding them to the media list.Tests
python -m pytest tests/gateway/test_media_extraction.py tests/gateway/test_platform_base.py -q -o 'addopts='Verification
Fixes #16434