fix(vision): preserve ZAI credential resolution with custom base_url#16317
Closed
chenyunbo411 wants to merge 1 commit into
Closed
fix(vision): preserve ZAI credential resolution with custom base_url#16317chenyunbo411 wants to merge 1 commit into
chenyunbo411 wants to merge 1 commit into
Conversation
Keep the configured vision provider when base_url is overridden so credential-pool lookup still resolves provider-specific API keys (e.g. ZAI_API_KEY), and add a regression test for this path.
This was referenced Apr 27, 2026
Contributor
|
Salvaged via #19726 onto current main - your commit authorship was preserved. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
resolve_vision_provider_clientso a configured explicit provider (for examplezai) is preserved whenauxiliary.vision.base_urlis set.ZAI_API_KEY) instead of forcing the route tocustom.provider=zai + custom base_urlresolution behavior.Test plan
pytest -q -o addopts='' tests/agent/test_vision_resolved_args.pyopenaipackage is missing (ModuleNotFoundError: No module named 'openai').Made with Cursor