fix: pass base_url and api_key to background review AIAgent#15884
Open
Kailigithub wants to merge 1 commit into
Open
fix: pass base_url and api_key to background review AIAgent#15884Kailigithub wants to merge 1 commit into
Kailigithub wants to merge 1 commit into
Conversation
Collaborator
19 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
_spawn_background_review()creates a background reviewAIAgentwithout passingbase_urlorapi_key. When the main agent uses a custom or fallback provider (e.g. OpenRouter, Cerebras, SiliconFlow), the review agent cannot:custom_providers(which requiresbase_urlto match)/modelsAPIs for context length detectionThis causes the review agent to fall through to live API detection, which may return the model's real context window and trigger the
MINIMUM_CONTEXT_LENGTH(64K) guard — silently killing the review thread.Fix
Pass
base_urlandapi_keythrough to the reviewAIAgentconstructor so it inherits the same provider configuration as the main agent.Testing
python3 -m py_compile run_agent.py— passespython3 -m pytest tests/run_agent/test_background_review_summary.py -v— 8/8 passedinspect.getsource(AIAgent._spawn_background_review)Closes #15882