fix(codex): honor runtime base url#15855
Closed
masterkain wants to merge 1 commit into
Closed
Conversation
19 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
summary
resolve_codex_runtime_credentials()soHERMES_CODEX_BASE_URLis honoredopenai-codexcredential-pool entries with the runtime Codex base URL instead of always storing the ChatGPT defaultraw_codex=Trueclients on the same runtime-resolved Codex URL and add regressions for both auxiliary pathsFixes #5875
verification
uv run --extra dev python -m pytest tests/agent/test_auxiliary_client.py tests/agent/test_credential_pool.py tests/hermes_cli/test_runtime_provider_resolution.py -q->208 passed, 12 warningsuv run --extra dev ruff check .-> passes with the current repo config (warning: No Python files found under the given path(s)because[tool.ruff] exclude = ["*"])uv run --extra dev python -m py_compile agent/auxiliary_client.py agent/credential_pool.pyuv run --extra dev python -m pytest tests/ -q-> not green locally: missing optional deps (acp,numpy,fastapi) and unrelated failures across gateway/web/transcription/filesystem tests