fix(cli): sync use_gateway in _reconfigure_provider for tts, browser, and web#15669
Closed
nftpoetrist wants to merge 1 commit into
Closed
fix(cli): sync use_gateway in _reconfigure_provider for tts, browser, and web#15669nftpoetrist wants to merge 1 commit into
nftpoetrist wants to merge 1 commit into
Conversation
… and web _reconfigure_provider() updates cloud_provider/backend/tts.provider when switching tool providers via "hermes setup tools → Reconfigure", but did not update the matching use_gateway flag. _configure_provider() (the initial-setup path) sets use_gateway on all three tool categories. The omission in _reconfigure_provider leaves a stale value in config.yaml: switching from a Nous-managed provider (use_gateway=True) to a self-hosted one keeps use_gateway=True, continuing to route requests through the Nous gateway; switching the other way leaves use_gateway unset so the managed feature does not activate. Fix: mirror _configure_provider's use_gateway = bool(managed_feature) assignment in the tts, browser, and web blocks of _reconfigure_provider. Symmetric across all three tool categories. No behavior change for any provider that does not set tts_provider, browser_provider, or web_backend. Fixes NousResearch#15229
Collaborator
Contributor
Author
|
#15349 was our own previous PR — closed intentionally to rebase onto current main after a merge conflict in #10690, #5096, #8240, and #14382 fix a different bug: the session-info banner in |
This was referenced Apr 27, 2026
Contributor
|
Salvaged via #19633 onto current main - your commit authorship was preserved. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
_reconfigure_provider()updatescloud_provider/backend/tts.providerwhen switching tool providers via "hermes setup tools → Reconfigure", but did not update the matchinguse_gatewayflag._configure_provider()(the initial-setup path) setsuse_gatewayon all three tool categories. The omission in_reconfigure_providerleaves a stale value inconfig.yaml: switching from a Nous-managed provider (use_gateway=True) to a self-hosted one keepsuse_gateway=True, continuing to route requests through the Nous gateway; switching the other way leavesuse_gatewayunset so the managed feature does not activate.Fix: mirror
_configure_provider'suse_gateway = bool(managed_feature)assignment in thetts,browser, andwebblocks of_reconfigure_provider. Symmetric across all three tool categories. No behavior change for any provider that does not settts_provider,browser_provider, orweb_backend.Related Issue
Fixes #15229
Type of Change
Changes Made
hermes_cli/tools_config.py: adduse_gatewaysync in_reconfigure_provider()for tts, browser, and web blocks (+8 lines)tests/hermes_cli/test_tools_config.py: parametrized regression test + stale-flag overwrite test (+29 lines)How to Test
Checklist
Code
Documentation & Housekeeping