feat(cli): implement hermes update --check flag#15589
Closed
Feranmi10 wants to merge 2 commits into
Closed
Conversation
Fixes NousResearch#9565 The CLI was using ⚕ (Rod of Asclepius, U+2625) which is a medical symbol unrelated to Hermes. Replaced all instances with ☤ (Caduceus, U+2624) — the actual staff of Hermes, consistent with the project's namesake and ASCII art logo.
Contributor
Author
|
The 11 test failures are pre-existing and unrelated to this change — they affect web_server, hindsight_provider, and tool_arg_coercion, none of which are touched by this PR. Happy to add tests for the --check flag if that would help |
Contributor
|
Merged via PR #15841 — cherry-picked your |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Implements the missing
--checkflag for thehermes updatecommand.The flag is documented in the official docs but was never implemented, causing an
unrecognized arguments: --checkerror when users try to run it.The implementation:
--checkargument to the update subparser_cmd_update_check()function that runsgit fetchthen compares HEAD toorigin/mainRelated Issue
Fixes #10318
Type of Change