fix(doctor): avoid false unknown provider for kimi-coding-cn#15583
Closed
VinVC wants to merge 3 commits into
Closed
fix(doctor): avoid false unknown provider for kimi-coding-cn#15583VinVC wants to merge 3 commits into
VinVC wants to merge 3 commits into
Conversation
added 2 commits
May 3, 2026 09:52
- Rebased on upstream/main to resolve conflicts - Added test_run_doctor_accepts_kimi_coding_cn_provider test - All 30 tests pass
Author
|
Hi @alt-glitch — merge conflicts have been resolved. This is ready for review when you have a chance. Thanks! |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
hermes doctorvalidationkimi-coding-cnthrough the shared models.dev alias table before checking known providerskimi-coding-cnprovider diagnostic pathWhy
kimi-coding-cnis a valid Hermes provider, buthermes doctorresolves it throughresolve_provider_full()before validation. The shared alias table mapskimi-coding-cnto the models.dev provider idkimi-for-coding, which is not in doctor's known provider set, so doctor reports a false unknown-provider issue even though the configured provider is supported.This is separate from #9734, which handles
KIMI_CN_API_KEYdetection and the Kimi China connectivity probe.Tests
/home/bot/.hermes/hermes-agent/venv/bin/python -m pytest tests/hermes_cli/test_doctor.py -q23 passed, 2 warnings